Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-2444] Docs: Add note about POLICY_KEY_SEND and list possible map key types #584

Merged
merged 8 commits into from
Mar 11, 2024

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Feb 21, 2024

Docs:
https://aerospike-python-client--584.org.readthedocs.build/en/584/aerospike.html#aerospike.POLICY_KEY_SEND
https://aerospike-python-client--584.org.readthedocs.build/en/584/data_mapping.html#data-mappings

Extra changes:

  • Modified test_expressions_map.py so it passes on both servers < 7.1 and server 7.1.
  • test_geospatial.py: only run certain tests on server < 7.1

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@376085b). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #584   +/-   ##
======================================
  Coverage       ?   81.39%           
======================================
  Files          ?       98           
  Lines          ?    14921           
  Branches       ?        0           
======================================
  Hits           ?    12145           
  Misses         ?     2776           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 changed the title [CLIENT-2444] Docs: Add note about POLICY_KEY_SEND [CLIENT-2444] Docs: Add note about POLICY_KEY_SEND and list possible map key types Feb 22, 2024
@juliannguyen4 juliannguyen4 marked this pull request as ready for review March 11, 2024 21:35
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

@juliannguyen4 juliannguyen4 merged commit 0e9b25a into dev Mar 11, 2024
24 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-2444-doc-map-keys branch March 11, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants