Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-3099] Add support for error code 32 (XDR key busy) #662

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Aug 30, 2024

Extra changes:

  • Fix test node close listener test

Testing

Build artifacts passes except for noise
Massif memory usage looks the same as before
Valgrind log looks similar as before. No memory errors

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.96%. Comparing base (0dad411) to head (e8d344e).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #662   +/-   ##
=======================================
  Coverage   80.96%   80.96%           
=======================================
  Files         100      100           
  Lines       15130    15130           
=======================================
  Hits        12250    12250           
  Misses       2880     2880           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 added the new-server-features Test against the latest server release candidate label Sep 9, 2024
@juliannguyen4 juliannguyen4 marked this pull request as ready for review September 16, 2024 19:32
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

@juliannguyen4 juliannguyen4 merged commit 25ac489 into dev Sep 16, 2024
151 of 158 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-3099-error-32 branch September 16, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-server-features Test against the latest server release candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants