-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLIENT-3106] Refactor aerospike module initialization code and check if error indicator is set after every C-API call #667
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #667 +/- ##
==========================================
- Coverage 80.96% 80.89% -0.08%
==========================================
Files 100 100
Lines 15130 15053 -77
==========================================
- Hits 12250 12177 -73
+ Misses 2880 2876 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6ed50e3
to
9ce9f15
Compare
…module-refactor
…module-refactor
…module-refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few double check questions. After you have had a look this LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Extra changes:
common
submoduleTODO