-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEVOPS-234] CI/CD: Reuse existing feature branch builds for valgrind runs #670
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #670 +/- ##
==========================================
- Coverage 80.79% 80.78% -0.01%
==========================================
Files 102 102
Lines 15173 15236 +63
==========================================
+ Hits 12259 12309 +50
- Misses 2914 2927 +13 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
This reverts commit 0242e35.
438cbef
to
92be52f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good
No merge conflicts with CLIENT-3027* PR
Reasons for this change:
It will be a while to clean up all the memory leaks while running the Python client regression tests, and we normally run valgrind manually. We won't be running valgrind as a CI/CD check for a while because of this. Often times, we run valgrind twice, so the second valgrind run builds a wheel when a wheel was already built for the same commit. This change forces valgrind to reuse a wheel (from JFrog) if it already exists
Known issues
Running the valgrind workflow on central branches (e.g
dev
) will build and upload the wheels to the generic JFrog repo. This shouldn't cause any issues but this isn't intended behavior.