Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVOPS-234] CI/CD: Reuse existing feature branch builds for valgrind runs #670

Merged
merged 61 commits into from
Nov 20, 2024

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Sep 11, 2024

No merge conflicts with CLIENT-3027* PR

Reasons for this change:
It will be a while to clean up all the memory leaks while running the Python client regression tests, and we normally run valgrind manually. We won't be running valgrind as a CI/CD check for a while because of this. Often times, we run valgrind twice, so the second valgrind run builds a wheel when a wheel was already built for the same commit. This change forces valgrind to reuse a wheel (from JFrog) if it already exists

  • Code reviewed
  • First valgrind run builds new wheel
  • Second valgrind run uses wheel built in first run
  • When there are two wheels for the same commit, the one with no labels is used
  • No regression when running valgrind run on central branch. Wheels should still be built before running job

Known issues
Running the valgrind workflow on central branches (e.g dev) will build and upload the wheels to the generic JFrog repo. This shouldn't cause any issues but this isn't intended behavior.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.78%. Comparing base (d8eff6e) to head (c2f438c).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #670      +/-   ##
==========================================
- Coverage   80.79%   80.78%   -0.01%     
==========================================
  Files         102      102              
  Lines       15173    15236      +63     
==========================================
+ Hits        12259    12309      +50     
- Misses       2914     2927      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@juliannguyen4 juliannguyen4 changed the title [DEVOPS-234] CI/CD: Reuse builds for feature branches in Github Actions workflows [DEVOPS-234] CI/CD: Reuse feature branch builds for valgrind runs if they already exist Nov 18, 2024
@juliannguyen4 juliannguyen4 changed the title [DEVOPS-234] CI/CD: Reuse feature branch builds for valgrind runs if they already exist [DEVOPS-234] CI/CD: Reuse existing feature branch builds for valgrind runs Nov 18, 2024
@juliannguyen4 juliannguyen4 force-pushed the DEVOPS-234-reuse-ft-branch-builds branch from 438cbef to 92be52f Compare November 18, 2024 20:06
@juliannguyen4 juliannguyen4 marked this pull request as ready for review November 20, 2024 18:23
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

@juliannguyen4 juliannguyen4 merged commit d95dfd5 into dev Nov 20, 2024
99 of 110 checks passed
@juliannguyen4 juliannguyen4 deleted the DEVOPS-234-reuse-ft-branch-builds branch November 20, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants