Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-3106] Fix reference count error caused by not properly incrementing reference count for Py_None object #672

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Sep 16, 2024

None's reference count needs to be managed properly for Python 3.11 and lower

https://docs.python.org/3.11/c-api/none.html#c.Py_None
https://docs.python.org/3.12/c-api/none.html#c.Py_None

Massif memory usage seems ok: https://github.com/aerospike/aerospike-client-python/actions/runs/10887384965/job/30209613022
No memory errors from valgrind: https://github.com/aerospike/aerospike-client-python/actions/runs/10887382672

Build wheels macOS x86 tests fail fast even though I disabled that. Have to investigate later, but besides that, it should be fine

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.96%. Comparing base (d1e7bc2) to head (63260df).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #672   +/-   ##
=======================================
  Coverage   80.96%   80.96%           
=======================================
  Files         100      100           
  Lines       15130    15132    +2     
=======================================
+ Hits        12250    12252    +2     
  Misses       2880     2880           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 marked this pull request as ready for review September 16, 2024 17:43
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks good

@juliannguyen4 juliannguyen4 merged commit 45ad62a into dev Sep 16, 2024
163 of 198 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-3106-ref-count-fix branch September 16, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants