Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial AVS 0.11.0 support #17

Merged
merged 14 commits into from
Oct 23, 2024
Merged

Initial AVS 0.11.0 support #17

merged 14 commits into from
Oct 23, 2024

Conversation

dwelch-spike
Copy link
Contributor

@dwelch-spike dwelch-spike commented Oct 22, 2024

This PR makes asvec compatible with AVS 0.11.0's grpc protocol by pulling in its protobuf spec and making relevant changes. It also adds a few features, they are...

  • The ability to set enableVectorIntegrityCheck through index create and index update aswell as view it in index ls vec-395
  • Adds --hnsw-batch-reindex-interval and --hnsw-batch-max-reindex-records to index create and index update, also exposes them in index ls. vec-402
  • BREAKING: Renames --hnsw-batch-max-records to --hnsw-batch-max-index-records and --hnsw-batch-interval to --hnsw-batch-index-interval to reflect renames in the protobuf. vec-403
  • Exposes indexed vector records and vertices in index ls. vec-396

Still to come in another PR

  • Support for record caching
  • Index ls output with index size and percent unmerged
  • Update the Go client to a released version
    ^ I will do all of these before making a release.

@dwelch-spike dwelch-spike self-assigned this Oct 22, 2024
@dwelch-spike dwelch-spike marked this pull request as draft October 22, 2024 22:31
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 95.87629% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.45%. Comparing base (b7de05e) to head (ec0be38).

Files with missing lines Patch % Lines
cmd/utils.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   86.24%   86.45%   +0.21%     
==========================================
  Files          41       41              
  Lines        2777     2836      +59     
==========================================
+ Hits         2395     2452      +57     
- Misses        289      291       +2     
  Partials       93       93              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dwelch-spike dwelch-spike changed the title Avs 0.11.0 support Initial AVS 0.11.0 support Oct 22, 2024
@dwelch-spike dwelch-spike marked this pull request as ready for review October 22, 2024 23:40
cmd/flags/hnsw.go Show resolved Hide resolved
cmd/writers/indexList.go Show resolved Hide resolved
@dwelch-spike dwelch-spike merged commit 74f4ea3 into main Oct 23, 2024
6 checks passed
@dwelch-spike dwelch-spike deleted the avs-0.11.0-support branch October 23, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants