Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEC-430: linting and test #2

Merged
merged 12 commits into from
Jan 7, 2025
Merged

VEC-430: linting and test #2

merged 12 commits into from
Jan 7, 2025

Conversation

arrowplum
Copy link
Contributor

No description provided.

.github/workflows/build-chart-jfrog.yaml Dismissed Show resolved Hide resolved
.github/workflows/build-chart-jfrog.yaml Fixed Show fixed Hide fixed
.github/workflows/lint-test.yml Fixed Show fixed Hide fixed
.github/workflows/lint-test.yml Fixed Show fixed Hide fixed
.github/workflows/lint-test.yml Fixed Show fixed Hide fixed
.github/workflows/lint-test.yml Fixed Show fixed Hide fixed
…hart configuration and improve port handling. @davi17g this one strikes me as a little risky. I am trying to bring the work you had started over here but this port business is messing me up.
.github/workflows/lint-test.yml Fixed Show resolved Hide resolved
@arrowplum arrowplum requested a review from dwelch-spike January 3, 2025 20:30
Copy link

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arrowplum
Copy link
Contributor Author

@davi17g please have a look too but I am going to merge.

.github/workflows/lint.yaml Fixed Show fixed Hide fixed
Copy link
Contributor

@davi17g davi17g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to run the following command:
helm template --debug abs ./charts/aerospike-vector-search --values avs-values-auth.yaml
and looks like chart is rendered as expected so LGTM.

@arrowplum arrowplum merged commit e69349c into main Jan 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants