-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VEC-430: linting and test #2
Conversation
…arch chart (taken from helm-charts PR)
…hart configuration and improve port handling. @davi17g this one strikes me as a little risky. I am trying to bring the work you had started over here but this port business is messing me up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@davi17g please have a look too but I am going to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to run the following command:
helm template --debug abs ./charts/aerospike-vector-search --values avs-values-auth.yaml
and looks like chart is rendered as expected so LGTM.
No description provided.