Refactor du notifier Slack #1587
Open
+360
−587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mopolo
force-pushed
the
refactor-slack-notifier
branch
from
817bc75 to
b46d39e
Compare
Mopolo
force-pushed
the
refactor-slack-notifier
branch
from
b46d39e to
9c839f3
Compare
Ce refactor permet de moderniser le code du notifier en le rendant testable avec un client HTTP et un serializer à jour.
Mopolo
force-pushed
the
refactor-slack-notifier
branch
from
9c839f3 to
23aac0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
La dépendance
jms/serializer-bundledoit être mise à jour pour permettre un upgrade de Symfony. On ne peut pas encore installer la toute dernière version mais on peut au moins être en v5.La seule classe utilisant ce serializer semble être le notifier Slack.
Du coup j'en ai profité pour la moderniser et la tester (et j'ai bien galéré à comprendre atoum 😅).
J'ai testé tout ça sur un Slack privé et tout semble OK.