Skip to content

Commit

Permalink
review
Browse files Browse the repository at this point in the history
  • Loading branch information
unkcpz committed May 25, 2022
1 parent f9e30c0 commit cd2cfa3
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
4 changes: 0 additions & 4 deletions .vscode/settings.json

This file was deleted.

2 changes: 2 additions & 0 deletions aiida_optimade/cli/cmd_calc.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ def calc(obj: dict, fields: Tuple[str], force_yes: bool, silent: bool):
from aiida import load_profile
from aiida.cmdline.utils import echo

# The default aiida.cmdline loglevel inherit from aiida loglevel is REPORT
# Here we use INFO loglevel for the operations
echo.CMDLINE_LOGGER.setLevel("INFO")

try:
Expand Down
4 changes: 2 additions & 2 deletions aiida_optimade/translators/entities.py
Original file line number Diff line number Diff line change
Expand Up @@ -157,14 +157,14 @@ def _store_attributes_node_extra(self) -> None:
"(%s) Updating Node %s in AiiDA DB!", profile.storage_backend, self._pk
)
if profile.storage_backend == "psql_dos":
# TODO: this can be `set_extra` directly? is there performance issue with sqlite_zip?
# TODO: this can be `set_extra` directly? is there performance issue?
from aiida.storage.psql_dos.models.node import DbNode

with get_manager().get_backend().transaction() as session:
session.query(DbNode).filter(DbNode.id == self._pk).update(
values={"extras": extras}
)
# TODO: should be also support sqlite_zip

else:
raise AiidaError(
f'Unknown AiiDA backend "{profile.database_backend}" for profile'
Expand Down

0 comments on commit cd2cfa3

Please sign in to comment.