Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add featured Product component. #290

Merged
merged 9 commits into from
Apr 2, 2020
Merged

Conversation

rin
Copy link

@rin rin commented Mar 31, 2020

Issue: #288 (comment)

Still needs some styling, especially for mobile!

Screenshot 2020-03-31 at 16 58 56

@rin rin requested a review from lulen11 March 31, 2020 15:01
@vercel
Copy link

vercel bot commented Mar 31, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/aimementoring/website/pog3dpik5
✅ Preview: https://website-git-feature-hoodie-cta.aimementoring.now.sh

@lulen11 lulen11 temporarily deployed to website-v5-feature-hood-csukmb April 1, 2020 04:59 Inactive
@aime-bot
Copy link

aime-bot commented Apr 1, 2020

@lulen11 lulen11 temporarily deployed to website-v5-feature-hood-csukmb April 1, 2020 05:12 Inactive
@lulen11 lulen11 requested review from kbardi and mischacolley and removed request for lulen11 April 1, 2020 05:23
@lulen11
Copy link
Contributor

lulen11 commented Apr 1, 2020

Thanks @rin !! I've made some updates and now this is good tto go!! I think it's ready tto be merged in witht the next release but we need a couple of good reviews first please :) @mischacolley @kbardi

@charliemckenzie I put the pink border around it as a temporary style so that when we have more ttime, i can do the wavy pink background

@mischacolley mischacolley mentioned this pull request Apr 1, 2020
2 tasks
Copy link
Contributor

@kbardi kbardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, the only thing I found is image on mobile looks bigger than container
image

@lulen11
Copy link
Contributor

lulen11 commented Apr 1, 2020

thanks @kbardi ! that's fixed now :)

@lulen11 lulen11 temporarily deployed to website-v5-feature-hood-csukmb April 1, 2020 23:14 Inactive
@mischacolley
Copy link
Contributor

@lulen11 spacing here https://www.dropbox.com/s/rocg1wl7pf3gc83/Screenshot%202020-04-02%2012.36.45.png?dl=0

And formatting of Support INTV, checkout the Imagi-Nation Hoodie

@lulen11 lulen11 temporarily deployed to website-v5-feature-hood-csukmb April 2, 2020 06:05 Inactive
@lulen11 lulen11 temporarily deployed to website-v5-feature-hood-csukmb April 2, 2020 06:09 Inactive
@lulen11 lulen11 requested a review from kbardi April 2, 2020 06:09
@lulen11 lulen11 temporarily deployed to website-v5-feature-hood-csukmb April 2, 2020 06:19 Inactive
@lulen11 lulen11 temporarily deployed to website-v5-feature-hood-csukmb April 2, 2020 06:36 Inactive
@lulen11
Copy link
Contributor

lulen11 commented Apr 2, 2020

hey @mischacolley i updated the image aaand created the shop variable for future use 👏 (had to call rin briefly but yay to getting more knowledgable in React!)

@lulen11
Copy link
Contributor

lulen11 commented Apr 2, 2020

@kbardi could you please re-review? 🙌 thank you!

@lulen11 lulen11 merged commit 60dff25 into staging Apr 2, 2020
@lulen11 lulen11 mentioned this pull request Apr 5, 2020
5 tasks
kbardi pushed a commit that referenced this pull request Jun 26, 2020
Feature: Add featured Product component.
@kbardi kbardi deleted the feature/hoodie-cta branch June 26, 2020 02:28
camposcristian pushed a commit that referenced this pull request Jul 17, 2020
Feature: Add featured Product component.
camposcristian pushed a commit that referenced this pull request Jul 17, 2020
Feature: Add featured Product component.
Former-commit-id: 0ec5cd2
camposcristian pushed a commit that referenced this pull request Jul 17, 2020
Feature: Add featured Product component.
Former-commit-id: 0ec5cd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants