Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imagine page updates #433

Merged
merged 8 commits into from
May 8, 2020
Merged

Imagine page updates #433

merged 8 commits into from
May 8, 2020

Conversation

lulen11
Copy link
Contributor

@lulen11 lulen11 commented May 8, 2020

No description provided.

@vercel
Copy link

vercel bot commented May 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/aimementoring/website/hwrgchown
✅ Preview: https://website-git-feat-imagine-updates.aimementoring.now.sh

@lulen11 lulen11 requested a review from mischacolley May 8, 2020 02:40
@aime-bot aime-bot temporarily deployed to website-v5-feat-imagine-ocfsz8 May 8, 2020 02:40 Inactive
@camposcristian
Copy link
Contributor

camposcristian commented May 8, 2020

@lulen11 lulen11 temporarily deployed to website-v5-feat-imagine-ocfsz8 May 8, 2020 04:05 Inactive
@vercel vercel bot temporarily deployed to Preview May 8, 2020 04:51 Inactive
@lulen11 lulen11 temporarily deployed to website-v5-feat-imagine-ocfsz8 May 8, 2020 04:51 Inactive
@lulen11 lulen11 temporarily deployed to website-v5-feat-imagine-ocfsz8 May 8, 2020 04:52 Inactive
@lulen11
Copy link
Contributor Author

lulen11 commented May 8, 2020

hey @mischacolley i think it's ready for review but i may have missed something... can you run your eyes? i deleted all the old styles which i was hesitant to do but we can go looking in an old branch i guess

still gotta update the main gif

@mischacolley
Copy link
Contributor

@lulen11 can the buttons open in a new tab please

@lulen11
Copy link
Contributor Author

lulen11 commented May 8, 2020

@lulen11 can the buttons open in a new tab please

this is a thing we reeeally need to do on blueprint... currently the button component doesn't allow for it. i'll create an issue for us (@kbardi or me) to address it asap

@lulen11 lulen11 temporarily deployed to website-v5-feat-imagine-ocfsz8 May 8, 2020 05:13 Inactive
@lulen11 lulen11 requested a review from charliemckenzie May 8, 2020 05:17
@lulen11 lulen11 temporarily deployed to website-v5-feat-imagine-ocfsz8 May 8, 2020 05:36 Inactive
@lulen11 lulen11 temporarily deployed to website-v5-feat-imagine-ocfsz8 May 8, 2020 05:54 Inactive
@lulen11 lulen11 merged commit 63b47ae into staging May 8, 2020
@lulen11 lulen11 deleted the feat/imagine-updates branch May 8, 2020 06:57
kbardi pushed a commit that referenced this pull request Jun 26, 2020
camposcristian pushed a commit that referenced this pull request Jul 17, 2020
camposcristian pushed a commit that referenced this pull request Jul 17, 2020
camposcristian pushed a commit that referenced this pull request Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants