Add Python 3.12 to test matrix #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wong2
approved these changes
Mar 31, 2024
aisk
force-pushed
the
py312-ci
branch
2 times, most recently
from
99194ea to
012e012
Compare
|
The ubuntu-18.04 CI worker seems deprecated and will be queued for a really long time: actions/runner-images#6002 If there is no a specified reason to run the test under it, I'll remove it in this PR. cc @wong2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update pyyaml to 6.0.1
The current pyyaml version
6.0.0, which is pinned in the lock file, hasn't released a wheel format version for Python 3.12, which makes it difficult to install on the CI server. This change updates the pyyaml version to 6.0.1 to avoid this issue.Update windows-curses to 2.3.2
Windows-curses only supports Python 3.12 in version 2.3.2, so we have bumped the version to that one.
Update poetry to 1.5.1 in GHA
Poetry's lock file cannot be used with different versions, and we are using version 1.2 in GitHub Actions. However, when I used it on my local machine to update the lock file when bumping pyyaml versions, it took almost an hour and didn't finish the job.
Poetry 1.5.1 is the last version that supports Python 3.7, so I have just updated it to this version. Maybe we should drop support for Python 3.7 in the future, as it's outdated and maintaining it may introduce a lot of trouble.