Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs for Euclidean Algorithm #1721

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

ShudarsanRegmi
Copy link
Contributor

📥 Pull Request

Description

I've added Euclidean Algorithm in number theory which is famous for finding gcd between two numbers

Fixes #1711

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

github-actions bot commented Nov 1, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible.). If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

github-actions bot commented Nov 1, 2024

⚡️ Lighthouse Report for the Deploy Preview of this PR 🚀

🔗 Site: Algo | Live Site

URL 🌐 Performance Accessibility Best Practices SEO 📊
/algo/ 🟡 51 🟢 96 🟡 75 🟡 86 📄
/algo/docs 🔴 47 🟢 96 🟡 75 🟢 100 📄
/algo/blog 🟡 68 🟢 92 🟢 96 🟡 86 📄

Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update your code based on suggestions

Comment on lines 61 to 65
### Example 1: GCD of 56 and 98
1. $$ 98 \mod 56 = 42 $$
2. $$ 56 \mod 42 = 14 $$
3. $$ 42 \mod 14 = 0 $$

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write in good format because

$ is used for inline and $$ is used for block and content in center so, follow best practices rule.


$$ a = b \times q + r $$

where $$ q $$ is the quotient and $$ r $$ is the remainder.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace $$ with $

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the changes as requested. Please check it @ajay-dhangar

@ajay-dhangar ajay-dhangar added gssoc-ext Contributions made as part of GirlScript Summer of Code Extended Edition. level1 GirlScript Summer of Code | Contributor's Levels labels Nov 2, 2024
Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ajay-dhangar ajay-dhangar merged commit c6c45e8 into ajay-dhangar:main Nov 2, 2024
5 checks passed
Copy link

github-actions bot commented Nov 2, 2024

🎉🎉 Thank you for your contribution! Your PR #1721 has been merged! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext Contributions made as part of GirlScript Summer of Code Extended Edition. level1 GirlScript Summer of Code | Contributor's Levels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: <Euclidean Algorithm> Adding Euclidean Algorithm in Number Theory
2 participants