Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INCLUDES SORTING VISUALIZING OF ALL SORTING ALGORITHMS #1734

Merged
merged 7 commits into from
Nov 4, 2024
Merged

INCLUDES SORTING VISUALIZING OF ALL SORTING ALGORITHMS #1734

merged 7 commits into from
Nov 4, 2024

Conversation

Meetpidev
Copy link
Contributor

📥 Pull Request

Description

INCLUDES SORTING VISUALIZING OF ALL SORTING ALGORITHMS

Fixes #1286

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • [ YES ] My code follows the style guidelines of this project
  • [ YES ] I have performed a self-review of my code
  • [ YES ] I have commented my code, particularly in hard-to-understand areas
  • [ YES ] I have added tests that prove my fix is effective or that my feature works
  • [ YES ] New and existing unit tests pass locally with my changes
  • [ YES ] Any dependent changes have been merged and published in downstream modules

@Meetpidev
CSS For styling
72569b4 
Added css
@Meetpidev
Update docusaurus.config.js
b391bcc 
Added Route
@Meetpidev
Sorting Visualinge Logic
9d67564 
Added Sorting Visualinge Logic.
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible.). If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Meetpidev
Copy link
Contributor Author

@ajay-dhangar Requested to review

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2024 •
edited
Loading

⚡️ Lighthouse Report for the Deploy Preview of this PR 🚀

🔗 Site: Algo | Live Site

URL 🌐 Performance Accessibility Best Practices SEO 📊
/algo/ 🟡 64 🟢 96 🟡 75 🟡 86 📄
/algo/docs 🟡 52 🟢 96 🟡 75 🟢 100 📄
/algo/blog 🟡 68 🟢 92 🟢 96 🟡 86 📄

@Meetpidev
Copy link
Contributor Author

@ajay-dhangar Please Review IT..

@ajay-dhangar ajay-dhangar added gssoc-ext Contributions made as part of GirlScript Summer of Code Extended Edition. level1 GirlScript Summer of Code | Contributor's Levels labels Nov 2, 2024
@Meetpidev
Copy link
Contributor Author

Meetpidev commented Nov 2, 2024 •
edited
Loading

@ajay-dhangar

Requested to accept it with level 3 as its includes ALL the sorting algorithm with visualization... we can also change the size of array... we can also manage the speed....

@ajay-dhangar ajay-dhangar added level3 GirlScript Summer of Code | Contributor's Levels and removed level1 GirlScript Summer of Code | Contributor's Levels labels Nov 3, 2024
ajay-dhangar
ajay-dhangar requested changes Nov 3, 2024
View reviewed changes
Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write your code in the Component folder and use it as a component, not as a page. This will make it easier to maintain and reuse.

@Meetpidev
Copy link
Contributor Author

Please write your code in the Component folder and use it as a component, not as a page. This will make it easier to maintain and reuse.

Its done please Review again....

@Meetpidev
Copy link
Contributor Author

@ajay-dhangar I replace code in component folder... please review it

@Meetpidev
Copy link
Contributor Author

@ajay-dhangar Please Review PR..

ajay-dhangar
ajay-dhangar requested changes Nov 3, 2024
View reviewed changes
Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not using a link for the url and pages, so can you delete the code based on the suggestions

docusaurus.config.js Outdated
Comment on lines 107 to 111
{
to: "Visualizing",
label: "Sorting Visualizer",
position: "left",
},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete lines 107 to 111

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it.. please Review Again...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i removed it but when should i render it ? should i render it in home page ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested to guid me

@Meetpidev
Copy link
Contributor Author

@ajay-dhangar I removed it.. please Review again...

ajay-dhangar
ajay-dhangar approved these changes Nov 4, 2024
View reviewed changes
Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ajay-dhangar ajay-dhangar merged commit 813d64e into ajay-dhangar:main Nov 4, 2024
5 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

🎉🎉 Thank you for your contribution! Your PR #1734 has been merged! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajay-dhangar ajay-dhangar ajay-dhangar approved these changes

Assignees

@Meetpidev Meetpidev

Labels
gssoc-ext Contributions made as part of GirlScript Summer of Code Extended Edition. level3 GirlScript Summer of Code | Contributor's Levels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Add Visualization of All sorting algorithms
2 participants
@Meetpidev @ajay-dhangar