Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Easy mode" #348

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

"Easy mode" #348

wants to merge 3 commits into from

Conversation

ajwheeler
Copy link
Owner

@ajwheeler ajwheeler commented Oct 17, 2024

Implements the higher level interface described in #339

TODO

  • unify with fit

Copy link
Contributor

github-actions bot commented Nov 7, 2024

TODOs found in this PR:

src/synth.jl:24:        # TODO this induces edge effects
src/synth.jl-25-        flux = apply_LSF(flux, spectrum.wavelengths, R)
src/synth.jl-26-    end
src/synth.jl-27-    if vsini > 0

flux = apply_rotation(flux, spectrum.wavelengths, vsini)
end
spectrum.wavelengths, flux, spectrum.cntm
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
end
end

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Project coverage is 80.05%. Comparing base (bcc0438) to head (403724f).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/synth.jl 0.00% 12 Missing ⚠️
src/abundances.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
- Coverage   80.51%   80.05%   -0.46%     
==========================================
  Files          28       29       +1     
  Lines        2232     2246      +14     
==========================================
+ Hits         1797     1798       +1     
- Misses        435      448      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant