settings: Add initial implementation for custom welcome bot message. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use 'get_realm_time_limits_in_minutes' function to get the value to be put in the custom input element. Previously, we returned "null" for the case when the setting was set to "Anytime", but now we instead return an empty string as returning null created some issues while converting the file to typescript. There is no change in behavior due to this as in both cases the input will be empty.
"Number.parseFloat" only accepts one string parameter and no other parameter like radix passed in Number.parseInt.
This commit updates code in check_property_changed to handle all time limit settings in the same switch case.
…lue. We now pass HTML element to get_input_element_value instead of JQuery object so that we can easily assert types later when we migrate the file to typescript.
There is no need to enclose a jquery object by "$".
The function check_property_changed is called at two places - we pass elem as HTML object in one call and JQuery object in another. We should make it consistent and we now pass HTML object in both the calls as that would be better when we would convert settings_components file to typescript.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Refactor `email_page` view to use `typed_endpoint` decorator instead of `has_request_variables`.
Links to the available message flag table in the feature level 224 changelog entry, as there are relevant **Changes** notes for this feature level in that part of the API documentation. Updates the order and formatting of these new and deprecated flags in the available flags table. Also, adds a link to the topic wildcard mentions section of the help center documentation. Makes small clean ups to the changes notes for this feature level, as well as the changelog entry itself. The original commit for these feature level 224 API changes was c597de6.
This fixes a regression introduced in the commit making typeahead undo friendly, d88ce61. This fixes the bug where selecting a topic via keyboard in the compose recipient area did not update the fade.
For function `filter_drafts_by_compose_box_and_recipient` since the set of drafts to filter from is almost definitely going to always be all drafts, we make the required drafts parameter optional with the default value of all drafts. This is a prep commit for the next commit which will use this function.
Now we show the number of drafts that are addressed to the current recipient selected in the compose box, if any, in the Drafts button within parentheses (whether it is next to the Send button, or in the Send options popover), and explain that it is the number of drafts for this conversation in the tooltip. Fixes: zulip#28696.
We emulate the same behaviour of hiding topic visibility button by using opacity if for default topic visibility state.
This commit updates label for name input in account creation form to "Name". Fixes part of zulip#29226.
This commit updates the placeholder for name input in account creation form to "Your full name". We also removes the "名前" since that confuses the user who do not know the language. This text was originally added to indicate that the name field supports unicode characters, which most modern apps do currently, so there is no need to add this text in the placeholder. Fixes part of zulip#29226.
This commit renames "Full name" field in profile settings, "Edit user" form and in the email modal for demo orgs to "Name". Fixes part of zulip#29226.
This commit updates the label for name field in login confirmation form for billing to "Name". Fixes part of zulip#29226.
This commit adds description text below the name field mentioning where the field will be used. Fixes part of zulip#29226.
This commit adds description text below the name field in profile settings panel mentioning how the field will be used. Fixes zulip#29226.
Co-authored-by: Greg Price <greg@zulip.com>
Minor refactor that makes sense to do.
Regardless of plan renewal schedule, we try to invoice all plans monthly with some exceptions like free trial and fixed price plans, which help us charge users for additional licenses used during the previous month.
42dd55d incorrectly deleted this.
Whenever a setting that needs confirmation to save is tweaked, and the save button is not visible, we scroll it into view, to ensure the user does not mistake it for an automatically saved change and misses saving their change. Fixes: zulip#29290.
If the remote realm registered after the legacy plan on server ENDED, we never migrate the plan to the remote realm. So, we need to check the server of remote realm whenever we are check remote realm for legacy plan.
When composing to an empty topic, only the compose box topic is changed to remove the tick-prefix from it. Fixes zulip#29182.
Earlier, the Shift + M shortcut only functioned in messages to mute/unmute topics in the messages section. This commit enables the Shift + M shortcut to work in recent conversations and the inbox. It achieves this by utilizing the existing function toggle_topic_visibility_policy in user_topics_ui. The focused row message of the recent_view_ui is passed to mute/unmute the selected topic in the recent_view_ui, and the same process is applied to the inbox_ui but the logic of muting/unmuting the topic is kept in inbox_ui which uses function toggle_topic_visibility_policy in user_topics_ui. The function toggle_topic_visibility_policy is called in both cases based on specific conditions to prevent the shortcut from affecting other parts of the page, thus avoiding errors. Fixes zulip#27741.
This is important step to fix a bug related to making sure css for `.column-right` doesn't apply in navbar but only `.app-main`.
While they might be useful, it create a potential for elements that we want to display on wide widths for a setting like hide user list but was bugged due to a css class like this.
We always want to render Zulip at maximum available width with a max-width.
We migrated from bootstrap dropdown to use tippy. This change should have been removed as part of that change.
We use `#navbar-middle` and `.app-main .column-middle` specifically to apply styles to those elements.
Navbar and app share same class for sidebar, so it is important that we specify which one we are referring to if we are not referring to both of them.
We might wrap more elements in future but this this is enough for testing that nothing breaks right now. Use `git show -w` for the real changes.
Fix a bug where the tooltip for the scroll to bottom button would remain visible after the button disapeared, if the user was hovering over the button as it was dissapearing, without moving their mouse. Now, the tooltip dissapears when the button finishes the visibility transition. Fixes zulip#28656
We redesign the message history modal to make it look similar to the drafts and scheduled messages, using the shared styling/rendering logic for that those existing elements to have a less goofy widget. Fixes zulip#28695.
Previously, if such a stream were in certain positions in message edit history, it would incorrectly be displayed as the empty string.
When a customer with plan's status 'DOWNGRADE_AT_END_OF_FREE_TRIAL' visits /billing page on the free-trial end date before the invoice cron runs, the 'make_end_of_cycle_updates_if_needed' downgrades the plan. Earlier, when such a customer visited /billing page in this time window it resulted in an assertion error. This commit fixes the incorrect behaviour by redirecting to '/plans' page in such cases.
To improve onboarding experience, this commit adds a one-time modal which introduces the inbox view. Users see this one-time modal on visiting the inbox view. Fixes part of zulip#29073.
To improve onboarding experience, this commit adds a one-time modal which introduces the recent conversations view. Users see this one-time modal on visiting the recent conversations view. Fixes zulip#29073.
We don't want to show one-time modals introducing 'Inbox' and 'Recent conversations' views to existing users. When a user views a modal, we mark it as read by storing a row in the 'OnboardingStep' model. Once marked as read, the user will no longer see the modal. This commit adds a migration to create two rows per user (mark them as read) in OnboardingStep model.
This makes the subsequent bullet resume its numbering correctly.
This only defaults to on for local-disk backups, since they are more disk-size-sensitive, and local accesses are quite cheap compared to loading multiple incremental backups from S3.
This fixes a bug where alert words that are contained in another alert word would have only the smaller alert word highlighted. Note that it does not handle weirder cases, like "one two" and "two three" being alert words; "two three" will always be highlighted, and not "one"; this is probably fine in practice. Fixes: zulip#28415 Co-Authored-By: danieldotcomcoder <daniel_shdeed@hotmail.com>
This commit extends the functionality of the Welcome Bot to include the custom welcome message configured by administrators. It ensures that new users receive the additional custom message along with the standard welcome message upon joining the organization. Fixes: zulip#27663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.