refactor: make it simple stupid (#66)

lib/persistence/Repository.ts

@@ -1,4 +1,3 @@
-import { Result } from '@lib/core'
 import { Aggregate, AnyIdentity } from '@lib/domain/models'
 import { Query } from '@lib/persistence'
 
@@ -13,19 +12,19 @@ export interface Repository<
    * Get all entities.
    * @returns All entities.
    */
-  all(): Promise<Result<readonly TEntity[]>>
+  all(): Promise<readonly TEntity[]>
 
   /**
    * Save entity.
    * @param entity Entity to save.
    */
-  save(entity: TEntity): Promise<Result<void, string>>
+  save(entity: TEntity): Promise<void>
 
   /**
    * Get entity by identity.
    * @param id Identity of the entity to load.
    */
-  get(id: TEntity['id']): Promise<Result<TEntity, string>>
+  get(id: TEntity['id']): Promise<TEntity>
 
   /**
    * Check if entity exists.
@@ -37,11 +36,11 @@ export interface Repository<
    * Find entities by query.
    * @param query Query to find entities by.
    */
-  find(query: Query<TEntity>): Promise<Result<readonly TEntity[]>>
+  find(query: Query<TEntity>): Promise<readonly TEntity[]>
 
   /**
    * Delete entity by identity.
    * @param id Identity of the entity to remove.
    */
-  delete(id: TEntity['id']): Promise<Result<void, string>>
+  delete(id: TEntity['id']): Promise<void>
 }

lib/persistence/memory/InMemoryRepository.ts

@@ -1,4 +1,3 @@
-import { Result } from '@lib/core'
 import { Aggregate, AnyIdentity } from '@lib/domain/models'
 import { Query } from '../Query'
 import { Repository } from '../Repository'
@@ -11,38 +10,34 @@ export class InMemoryRepository<
   protected entities = new Map<TEntity['id'], TEntity>()
   protected processor = new InMemoryQueryProcessor<TEntity>()
 
-  async all(): Promise<Result<readonly TEntity[]>> {
-    return Result.ok(Array.from(this.entities.values()))
+  async all(): Promise<readonly TEntity[]> {
+    return Array.from(this.entities.values())
   }
 
-  async save(entity: TEntity): Promise<Result<void, string>> {
+  async save(entity: TEntity): Promise<void> {
     const copy = Object.create(entity)
     Object.assign(copy, entity)
     this.entities.set(entity.id.value, copy)
-    return Result.ok()
   }
 
-  async get(id: TEntity['id']): Promise<Result<TEntity, string>> {
+  async get(id: TEntity['id']): Promise<TEntity> {
     const value = this.entities.get(id.value)
-    if (!value) { return Result.fail(`Entity '${id.value}' not found`) }
-    return Result.ok(value)
+    if (!value) { throw new Error(`Entity '${id.value}' not found`) }
+    return value
   }
 
   async exists(id: TEntity['id']): Promise<boolean> {
     return this.entities.has(id.value)
   }
 
-  async find(query: Query<TEntity>): Promise<Result<readonly TEntity[]>> {
+  async find(query: Query<TEntity>): Promise<readonly TEntity[]> {
     const entities = Array.from(this.entities.values())
-    return Result.ok(this.processor.execute(query, entities))
+    return this.processor.execute(query, entities)
   }
 
-  async delete(id: TEntity['id']): Promise<Result<void, string>> {
+  async delete(id: TEntity['id']): Promise<void> {
     const isExists = await this.exists(id)
-    if (!isExists) {
-      return Result.fail(`Entity '${id.value}' not found`)
-    }
+    if (!isExists) { throw new Error(`Entity '${id.value}' not found`) }
     this.entities.delete(id.value)
-    return Result.ok()
   }
 }