Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename widget "vi-command/edit-and-execute-line" to "vi-command/edit-and-execute-command" (correct name) #418

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

alexandregv
Copy link
Contributor

This PR edits file lib/core-decode.vi_nmap-rlfunc.txt:42 by changing vi-command/edit-and-execute-line to vi-command/edit-and-execute-command since it seems to be the correct name.

With the wrong name, when starting ble.sh with bash in vi mode, I got this error:

ble-bind: Unknown widget `vi-command/edit-and-execute-line'.

After the rename, no more error.

Here are my versions if debug is needed:

$ bash --version
GNU bash, version 5.2.2(1)-release (x86_64-redhat-linux-gnu)
$ ble --version
ble.sh (Bash Line Editor), version 0.4.0-devel4+ef8272a
$ dnf info --installed readline
Installed Packages
Name         : readline
Version      : 8.1
Release      : 6.fc36
Architecture : x86_64
Size         : 482 k
Source       : readline-8.1-6.fc36.src.rpm
Repository   : @System
From repo    : anaconda
Summary      : A library for editing typed command lines
URL          : https://tiswww.case.edu/php/chet/readline/rltop.html

Change widget `vi-command/edit-and-execute-line` to `vi-command/edit-and-execute-command` (correct name).
@akinomyoga
Copy link
Owner

Thank you for the report and the fix! This is the correct fix.

@akinomyoga akinomyoga merged commit 6aa8ba6 into akinomyoga:master Mar 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants