Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add folder name to generate dashboard uid #256

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rzcastilho
Copy link

Change description

Adds the grafana folder name when configured, to the dashboard uid.

What problem does this solve?

Prevents dashboard override in grafana in different folder names, and open the possibility to have dashboards of the same type to the same grafana for diferent enviromnets of the same application, for instance when you have dev/staging/production environments.

Issue number: (if applicable)

Example usage

...
  config :app_name, AppName.PromEx,
    disabled: false,
    manual_metrics_start_delay: :no_delay,
    drop_metrics_groups: [],
    grafana: [
      host: System.get_env("GRAFANA_HOST"),
      auth_token: System.get_env("GRAFANA_TOKEN",),
      upload_dashboards_on_start: true,
      folder_name: "App Name (#{app_env})",
      annotate_app_lifecycle: true
    ],
    metrics_server: :disable
...

Additional details and screenshots

Checklist

  • I have added unit tests to cover my changes.
  • I have added documentation to cover my changes.
  • My changes have passed unit tests and have been tested E2E in an example project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant