Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Optimize OptionsFlow (#2748) #2791

Merged
merged 2 commits into from
Jan 14, 2025
Merged

fix: Optimize OptionsFlow (#2748) #2791

merged 2 commits into from
Jan 14, 2025

Conversation

z-master42
Copy link
Contributor

Make #2748 compatible with Home Assistant version < 2024.12 and be more consistent in the implementation of https://developers.home-assistant.io/blog/2024/11/12/options-flow

@z-master42 z-master42 changed the title Optimize OptionsFlow (#2748) fix: Optimize OptionsFlow (#2748) Jan 6, 2025
@coveralls
Copy link

coveralls commented Jan 6, 2025

Pull Request Test Coverage Report for Build 12637378275

Details

  • 2 of 19 (10.53%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 9.425%

Changes Missing Coverage Covered Lines Changed/Added Lines %
custom_components/alexa_media/config_flow.py 2 19 10.53%
Totals Coverage Status
Change from base Build 12596243117: 0.02%
Covered Lines: 326
Relevant Lines: 3459

💛 - Coveralls

@alandtse
Copy link
Owner

alandtse commented Jan 8, 2025

Is this an actual fix of bad behavior or is it just an improvement? It determines whether this will cause a release. If it's just an improvement, I'd change to refactor or perf depending on the expected impact.

@z-master42
Copy link
Contributor Author

Ah, yes, of course. I would say that it is an improvement.

@danielbrunt57
Copy link
Collaborator

Make #2748 compatible with Home Assistant version < 2024.12

It looks more like a fix to me than an improvement if #2748 fails to work on HA < 2024.12...

@alandtse alandtse merged commit f519ac9 into alandtse:dev Jan 14, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants