feat(rn): add iOS support #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
moldy530
force-pushed
the
moldy/ios-base
branch
from
b8e5106 to
cd86ad5
Compare
moldy530
force-pushed
the
moldy/ios-base
branch
from
cd86ad5 to
1e378ab
Compare
moldy530
force-pushed
the
moldy/ios-base
branch
from
1e378ab to
4844dd7
Compare
7 tasks
moldy530
force-pushed
the
moldy/ios-base
branch
from
4844dd7 to
26f2f98
Compare
moldy530
requested review from
rthomare,
dancoombs,
mokok123,
dphilipson and
linnall
as code owners
moldy530
force-pushed
the
moldy/ios-base
branch
from
26f2f98 to
4a675f2
Compare
rthomare
approved these changes
Dec 20, 2024
moldy530
force-pushed
the
moldy/ios-base
branch
from
4a675f2 to
a35875d
Compare
7 tasks
Merge activity
|
# Pull Request Checklist - [ ] Did you add new tests and confirm existing tests pass? (`yarn test`) - [ ] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)) - [ ] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`) - [ ] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`) - [ ] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)? <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the `account-kit/react-native-signer` library, including the addition of new functionality, improvements in the iOS implementation, and updates to project dependencies and configurations. ### Detailed summary - Added `NativeTEKStamperImpl` class with `create` method. - Enhanced `NativeTEKStamper` implementation with new methods. - Updated `package.json` with new author and description. - Modified `Podspec` to point to the new repository. - Added new files to the iOS project structure. - Updated `Gemfile.lock` with new dependencies. - Adjusted `xcodeproj` settings and identifiers. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
graphite-app
bot
force-pushed
the
moldy/ios-base
branch
from
a35875d to
2e3892c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR focuses on updating the
account-kit/react-native-signerlibrary, including new implementations in Swift and Objective-C, changes to project configurations, and updates to dependencies.Detailed summary
NativeTEKStamperImplclass inNativeTEKStamperImpl.swift.package.jsonwith new author and description.NativeTEKStamperinterface and implementation in Objective-C.ReactNativeSignerExample.Podfile.lockwith new dependency versions.account-kit-react-native-signer.podspec.Podfile.iosdirectory.Gemfile.lockwith new dependencies.