feat: enable discord social auth #1281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Pull Request Checklist - [x] Did you add new tests and confirm existing tests pass? (`yarn test`) - [x] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)) - [x] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [x] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [x] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`) - [x] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`) - [x] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)? <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the functionality of the `alchemyTransport` in the `account-kit` library. It introduces type guards, refactors client creation methods, and updates documentation to streamline the use of Alchemy transport across various account types. ### Detailed summary - Added `isAlchemyTransport` type guard in `alchemyTransport.js`. - Modified exports in `index.ts` to include `isAlchemyTransport`. - Refactored client creation functions to support dynamic transport. - Updated documentation for `isAlchemyTransport` and other functions. - Replaced deprecated client creation methods with new ones. - Enhanced test cases for multi-owner and light account clients. - Adjusted package scripts for type checking. - Improved sidebar references in documentation files. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
# Pull Request Checklist - [x] Did you add new tests and confirm existing tests pass? (`yarn test`) - [x] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)) - [x] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [x] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [x] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`) - [x] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`) - [x] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)? <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces a new type `NotType` to prevent certain type extensions and modifies various client creation functions to utilize this type. It also enhances test coverage for the `createSMAV2AccountClient` function to validate transport behavior and policy ID specifications. ### Detailed summary - Added `NotType` type to prevent type extensions. - Updated `createLightAccountClient`, `createMultiOwnerLightAccountClient`, `createMultiOwnerModularAccountClient`, and `createMultisigModularAccountClient` to use `NotType`. - Enhanced tests for `createSMAV2AccountClient` to check behavior with `AlchemyTransport`. - Added tests for policy ID and paymaster restrictions in `createSMAV2AccountClient`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
jcaleb4
requested review from
moldy530,
rthomare,
dancoombs,
mokok123,
dphilipson,
linnall,
adamegyed,
howydev,
Zer0dot,
jaypaik and
Blu-J
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)Loom video of the discord social auth working
https://www.loom.com/share/24d05b1aba104b03963dedcdd22ae57f
PR-Codex overview
This PR focuses on refactoring and enhancing the
account-kitlibrary, particularly around the handling of smart account clients and the introduction of new transport types. It includes the removal of deprecated functions, the addition of new icons, and improvements in type safety.Detailed summary
.mdxfiles related to smart contracts.NotTypeutility type for type safety.DiscordIcon,FacebookIcon,GoogleIcon, andAppleIcon.OAuthConnectionFailedcomponent to supportauth0ConnectionandlogoUrl.createLightAccountClientandcreateMultiOwnerLightAccountClientfunctions for better transport handling.aa-sdk/core.