feat(v2): 4337 v0.7 updates #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypaik
force-pushed
the
03-06-feat_4337_v0.7_updates
branch
from
0fb85c6 to
4b1bb9d
Compare
jaypaik
force-pushed
the
03-06-feat_4337_v0.7_updates
branch
from
4b1bb9d to
dea597b
Compare
adam-alchemy
approved these changes
Mar 11, 2024
| @@ -282,10 +284,10 @@ contract LightAccountTest is Test { | |||
| keccak256( | |||
| abi.encodePacked( | |||
| type(LightAccountFactory).creationCode, | |||
| bytes32(uint256(uint160(0x5FF137D4b0FDCD49DcA30c7CF57E578a026d2789))) | |||
| bytes32(uint256(uint160(0x0000000071727De22E5E9d8BAf0edAc6f37da032))) | |||
There was a problem hiding this comment.
We can replace this line with just abi.encode(<EntryPoint address>) to avoid dealing with the type conversions.
There was a problem hiding this comment.
Ack, will fix up the stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eth-infinitism/account-abstractionto track branchreleases/v0.7(commit7af70c8993a6f42973f520ae0752386a5032abe7)eth-infinitism/account-abtraction@releases/v0.7uses (commitdbb6104ce834628e473d2173bbc9d47f81a9eec3)forge-stdto track the branchv1so thatforge updateworks properly (commitae570fec082bfe1c1f45b0acca4a2b4f84d345ce)UserOperationwithPackedUserOperationeth-infinitism/account-abtraction@releases/v0.7Intentionally haven't updated the deploy script yet. Will do that after all v2 changes are in.