fix: [ALC-LA2-4] revert when transferring to 0 address #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypaik
commented
Apr 4, 2024
| @@ -21,14 +21,10 @@ abstract contract BaseLightAccount is BaseAccount, TokenCallbackHandler, UUPSUpg | |||
| CONTRACT_WITH_ADDR | |||
| } | |||
|
|
|||
| /// @dev The length of the array does not match the expected length. | |||
There was a problem hiding this comment.
These were self-explanatory, so removing to be consistent with errors in BaseLightAccountFactory.
howydev
reviewed
Apr 4, 2024
Base automatically changed from
04-04-fix_ALC-LA2-2_revert_on_malformed_signature
to
develop
April 5, 2024 20:09
jaypaik
force-pushed
the
04-04-fix_ALC-LA2-4_revert_when_transferring_to_0_address
branch
2 times, most recently
from
d8958c7 to
985a246
Compare
jaypaik
force-pushed
the
04-04-fix_ALC-LA2-4_revert_when_transferring_to_0_address
branch
from
985a246 to
680aafd
Compare
jaypaik
deleted the
04-04-fix_ALC-LA2-4_revert_when_transferring_to_0_address
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the recommendation to guard against address(0) transfers.