fix: [ALC-LA2-1] document internal function _getCombinedSalt to expect clean upper bits for owner #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypaik
force-pushed
the
04-05-fix_ALC-LA2-3_remove_SignatureType.CONTRACT_case_from_MultiOwnerLightAccount__validateSignature_
branch
2 times, most recently
from
097595b to
cb2548d
Compare
Base automatically changed from
04-05-fix_ALC-LA2-3_remove_SignatureType.CONTRACT_case_from_MultiOwnerLightAccount__validateSignature_
to
develop
April 5, 2024 23:00
…t clean upper bits for owner
jaypaik
force-pushed
the
04-05-fix_ALC-LA2-1_document_internal_function__getCombinedSalt_to_expect_clean_upper_bits_for_owner
branch
from
a8421f9 to
f2fd387
Compare
jaypaik
deleted the
04-05-fix_ALC-LA2-1_document_internal_function__getCombinedSalt_to_expect_clean_upper_bits_for_owner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the owner parameter is passed in from an external call parameter, the upper bits should already be clean. But helpful to document this for
_getCombinedSalt.