-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PAWS][ENG-55567] Replace GCP collector npm library google-cloud-logging to googleapis to convert protopayload to json #372
Conversation
…ing to googleapis to convert protopayload to json
CI Service Job Number 1009 Logs - SUCCESS
Stages Run:
|
CI Service Job Number 1015 Logs - SUCCESS
Stages Run:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good only some indentation related comments.
…cket in s3 when self update (alertlogic#373)
30e9f8b
to
1712a5b
Compare
CI Service Job Number 1016 Logs - SUCCESS
Stages Run:
|
CI Service Job Number 1017 Logs - SUCCESS
Stages Run:
|
5357a6f
to
0a8353c
Compare
CI Service Job Number 1018 Logs - SUCCESS
Stages Run:
|
CI Service Job Number 1020 Logs - SUCCESS
Stages Run:
|
CI Service Job Number 1026 Logs - SUCCESS
Stages Run:
|
…ing to googleapis to convert protopayload to json
CI Service Job Number 1027 Logs - SUCCESS
Stages Run:
|
build-collector-googlestackdriver |
CI Service Job Number 1028 Logs - SUCCESS
Stages Run:
|
Problem Description
[GoogleStackDriver] Buffer portion of GCP log not being decoded for AuditLog type
Solution Description
Currently the npm package we use @google-cloud/logging for the GCP collector is returning protobuf for protoPayload which we then have to convert into json but json converted is verlong with type value for example(strinValue,numberValue and lots of uneccessary fields). this PR contains logic #365
but there is a npm package library that does this natively googleapis. We need to switch to use this library and thus remove the decoding that was added to convert to json.