Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #20

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

solution #20

wants to merge 2 commits into from

Conversation

vlevik
Copy link

@vlevik vlevik commented Oct 13, 2023

Copy link

@superpooperxxx superpooperxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good job🔥 If you had a little more time I think you would finish completely

Comment on lines +23 to +34
const users = [
{ id: 0, name: 'All' },
...usersFromServer,
];

const categories = [
{
id: 0,
title: 'All',
},
...categoriesFromServer,
];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting idea

Comment on lines +93 to +98
users.map(user => (
<a
data-cy={user.name === 'All'
? 'FilterAllUsers'
: 'FilterUser'
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot key

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants