Pass Candidate Protocol arounds along with Address(es) so that routing to the correct ICE route can be done cleanly. #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a string, and then utilize CandidateProtocol along with SocketAddr to uniquely identify a Candidates and Candidate pairs.
This makes it so we can use "udp" as a &str input instead of always importing the full CandidateProtocol enum.
This is to avoid dependency in the "wrong" direction. The Protocol is exposed in io/net::Transmit and thus can't be from the ice::* module.
It sits in io/net:: and is more broad than only for ICE candidates.
algesten
force-pushed
the
efer-ms-efer/candidates
branch
from
e018e85 to
c99e86e
Compare
davibe
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some commits to #389.
The changes from 389 are:
Candidate::host(ip, "udp").Close #389