Refactor MNN KleidiAI interface #3152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor MNN_KleidiAI interface to support more model types, and facilitate subsequent KleidiAI ukernels' integration. Re-abstract information stored in class KleidiAI: 1) static info: not related to loaded model, initialized when interface is constructed and never changed. 2) status: will change while pipeline is running. Let interface and loaded model decouple for more complex mix of multiple types of models. Add mAccelType in MNN data structure, kleidiAI interface will rely on this type to decide which branch to go. Move some pack functions to mnn_kleidiai_util.cpp. Add CPU feature detection in source/backend/cpu/CPURuntime.hpp. Subsequent ukernels need SME information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor MNN_KleidiAI interface to support more model types, and facilitate subsequent KleidiAI ukernels' integration.
Re-abstract information stored in class KleidiAI:
Let interface and loaded model decouple for more complex mix of multiple types of models. Add mAccelType in MNN data structure, kleidiAI interface will rely on this type to decide which branch to go.
Move some pack functions to mnn_kleidiai_util.cpp.
Add CPU feature detection in source/backend/cpu/CPURuntime.hpp. Subsequent ukernels need SME information.