Remove deprecated register modifier

[p12tic]

register modifier has been removed in C++17.

This has already been addressed upstream:

coin-or/CoinUtils@1700ed9

cc @fabiencastan

[p12tic]

@fabiencastan I think it would make sense to properly fork upstream repositories and add these as dependencies via git submodules. The current approach of having a repository that does not correspond to any of the upstream repositories is not optimal.

Basically I propose that we have the following 3 submodules in AliceVision:

• https://github.com/coin-or/CoinUtils
• https://github.com/coin-or/Clp
• https://github.com/coin-or/Osi

[simogasp]

The problem is that the original repos are not based on cmake, so that makes it difficult to build on windoze. That's why this repo was created to combine the 3 in a single one and a basic cmake support. We can look at vcpkg, how they created the cmake support there and maintain a version of the 3 with the patches provided by vcpkg. Just to avoid to redo and maintain yet another version for the 3

[p12tic]

@simogasp I that maintaining effort is the same regardless of whether we have 3 or 1 repository. Having said that I agree that there will be significant cost during switchover. I volunteer to implement the switch though, so this cost shouldn't matter too much to you.

Would you fork these 3 repositories to AliceVision organization and accept my PRs if I get everything to work?

[p12tic]

@simogasp I decided not to wait for your answer and see how far I can get if I just went to implement the conversion. It turns out it was much easier than I thought thanks to your suggestion to use vcpkg as a source. The CMake files needed some non-obvious changes to be able to fit into AliceVision as subprojects, but other than that everything was straightforward. AliceVision unit tests pass.

If you forked the repositories I listed to alicevision organization I would submit PRs implementing CMake functionality and then switch main AliceVision project to the new dependencies.

[simogasp]

great! I think if we can successfully build the 3 on Linux and windows it will be even better to remove the subproject altogether and use them only as external libs like any other lib. Nothing good comes in including another CMake project in my experience. And it will simplify the management of the lib (internal/external) and hopefully, one day, we will be able to add the vcpkg port of AV more smoothly

[simogasp]

They are forked
https://github.com/AliceVision/CoinUtils etc
Each one has a av_develop branch set as the default one on which we can make our version