Integration Testing! And some other QOL stuff #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` $ cargo test ``` now runs an integration test that uses the `gopro-chaptered-video-assembler` binary to create real video output. A merkle tree is then constructed, and the root node hash is compared with the expected output. I've verified that the test fails when unexpected files are in either of the directories, or the files don't match. The reliance on extensive manual testing was making it harder to want to work on this. Fix #12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12, #14
now runs an integration test that uses the
gopro-chaptered-video-assemblerbinary to create real video output. A merkle tree is then constructed,
and the root node hash is compared with the expected output. I've
verified that the test fails when unexpected files are in either of the
directories, or the files don't match.
The reliance on extensive manual testing was making it harder to want to
work on this.