Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build fix: update libsodium to get a build definition without aarch64_32 #1

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

dontlaugh
Copy link
Contributor

Opening this as a draft, because you already seem to be aware that libsodium support isn't available in zig v0.14.0

@dontlaugh dontlaugh force-pushed the libsodium-build-fix branch from 3b14201 to 1ba409d Compare October 11, 2024 00:15
@dontlaugh
Copy link
Contributor Author

dontlaugh commented Oct 11, 2024

There is no libsodium release tag that has this fix yet, unfortunately.

Asked for one upstream: jedisct1/libsodium#1416

@dontlaugh
Copy link
Contributor Author

As recommended, I'll update this to a commit from the stable branch. This is the most recent one:

3c6da4b8c27c7d546746eadabc9e2dd6c1fdfc2c

On recommendation from the libsodium dev, thir commit is from the "stable"
branch of libsodium, not a release tag. Update this to a release when one
containing this fix is available.
@dontlaugh dontlaugh force-pushed the libsodium-build-fix branch from 1ba409d to 5e0cdc8 Compare October 14, 2024 22:58
@dontlaugh dontlaugh marked this pull request as ready for review October 14, 2024 22:58
@torque torque merged commit 5e0cdc8 into allyourcodebase:master Oct 15, 2024
5 checks passed
@torque
Copy link
Collaborator

torque commented Oct 15, 2024

Thanks for taking the time to figure out the path forward on this.

@dontlaugh dontlaugh deleted the libsodium-build-fix branch October 15, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants