Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cart builder for product without image #21

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

Francois-Gomis
Copy link
Contributor

Reason for change

ClickUp task

Code changes

Check if first object in array is null

How to test

No test in local

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@Francois-Gomis Francois-Gomis merged commit 22d1d2f into main Dec 13, 2024
2 checks passed
@webaaz webaaz deleted the feature/ecom-2262-home-maison-error-sylius branch December 13, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants