little fix to support arabic in pdf. #83
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Me and #34 and many others in the community using the Arabic language need to use PDF export.
Proposal
using the library https://github.com/khaled-alshamaa/ar-php we can modify the outputted HTML to support our language.
how?
if ArPHP is installed on the system it will use it, by:
class_exists('ArPHP\I18N\Arabic')
why it's not required in composer?
I didn't require it in Composer because i don't think everybody needs Arabic support.
BTW:
if you think this should be installed on every project just require it
also, I think it would be great if we can mention it in the readme, but not sure.
Linked Issues & PRs
this helps #75 and follows #76 to support more locales (eg. Arabic)
and for sure fixes #34