Add accessibility controls to 'No results' list item #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
querkmachine
approved these changes
Aug 21, 2024
owenatgov
force-pushed
the
no-results-list-item
branch
from
bd31634 to
fd59e71
Compare
✅ Deploy Preview for accessible-autocomplete ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Adds `role="option"` and `aria-disabled="true"` to the rendered li when no results have been found. This ensures for screen readers who navigate to the 'no results' li that they know it's still semantically part of the autocomplete interface but not a valid option. This solution was recommended by DAC following a recent audit of the GOV.UK Design System website.
owenatgov
force-pushed
the
no-results-list-item
branch
from
fd59e71 to
929c81a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
role="option"andaria-disabled="true"to the rendered li when no results have been found. This ensures for screen readers who navigate to the 'no results' li that they know it's still semantically part of the autocomplete interface but not a valid option.This solution was recommended by DAC following a recent audit of the GOV.UK Design System website.
Resolves alphagov/govuk-design-system#4003