Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Yarn to version 4 #2975

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Upgrade Yarn to version 4 #2975

merged 1 commit into from
Nov 30, 2023

Conversation

ryanb-gds
Copy link
Contributor

davidgisbey
davidgisbey approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@davidgisbey davidgisbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryanb-gds ryanb-gds merged commit 0a13c15 into main Nov 30, 2023
11 checks passed
@ryanb-gds ryanb-gds deleted the upgrade-to-yarn-4 branch November 30, 2023 11:19
ryanb-gds added a commit that referenced this pull request Nov 30, 2023
@ryanb-gds
Revert "Merge pull request #2975 from alphagov/upgrade-to-yarn-4"
a4eba44 
This reverts commit 0a13c15, reversing
changes made to f59ae34.

This was causing a failed Docker image build because the Yarn 4 config and release files were not being copied to the image properly
ryanb-gds added a commit that referenced this pull request Nov 30, 2023
@ryanb-gds
Merge pull request #2976 from alphagov/revert-yarn-4-upgrade
30c75ef 
Revert "Merge pull request #2975 from alphagov/upgrade-to-yarn-4"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidgisbey davidgisbey davidgisbey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanb-gds @davidgisbey