Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EAS-2430 Send notification when user changes security information #179

Open
wants to merge 50 commits into
base: main
Choose a base branch
from
Open

EAS-2430 Send notification when user changes security information #179

wants to merge 50 commits into from

Conversation

leylayaltiligil
Copy link
Contributor

@leylayaltiligil leylayaltiligil commented Dec 19, 2024 •
edited
Loading

This PR consists of:

  • Functions for sending security information changed notifications, both SMS & email, using Notify templates
  • Adjustment to check_email_already_in_use route, to ensure if email address passed in is same as requesters email address then this is returned
  • Routes to be used when checking the parameter supplied is valid & appropriate i.e. not empty or same as existing etc
  • Function to return number of webauthn credentials that user has, for use in Admin application
  • Relevant tests for added functionality & adjustments to existing

@leylayaltiligil
Added template IDs to config
ab8171f
@leylayaltiligil
Added notification functions for security changes
b5e8828
@leylayaltiligil
Added notification logic to update_user_attribute route
9f3cd3b
@leylayaltiligil
Merge branch 'main' of https://github.com/alphagov/emergency-alerts-api…
46d8b39 
… into EAS-2430-send-notif-on-change
@leylayaltiligil
Added notifications when name or password updated
f49109e
@leylayaltiligil
Changed the test mobile numbers & email addresses from notify to dumm…
6f6ac36 
…y EA
@leylayaltiligil
Ensuring securirty notifications only sent for specific attribute cha…
b6efa73 
…nges
@leylayaltiligil
Updated dummy mobile number for tests
36b4219
@leylayaltiligil
Added security change notification sending with webauthn changes
f3aa408
@leylayaltiligil
Added securityy key change template ID
fa3bf01
@leylayaltiligil
Added functionality for sending security key change notification
886c2dc
@leylayaltiligil
Passing in text to security key notification function
3410c45
@leylayaltiligil
Merge branch 'main' of https://github.com/alphagov/emergency-alerts-api…
bbb8148 
… into EAS-2430-send-notif-on-change
@leylayaltiligil
Merge branch 'main' of https://github.com/alphagov/emergency-alerts-api…
4bb1553 
… into EAS-2430-send-notif-on-change
@leylayaltiligil
Removed generic security change email
4ab92ec
@leylayaltiligil
Added security details check routes for validation
a357d4e
@leylayaltiligil
Updated error response text
9ebfedc
@leylayaltiligil
Fixed incorrect indexing
6dd7cc5
@leylayaltiligil
Added tests for security detail validation routes
6f0ccbb
@leylayaltiligil
Added function to return number of credentials for given user & writt…
b3de8da 
…en test
@leylayaltiligil
Checking email against current user email
87bc4aa
@leylayaltiligil
Ensuring user_id passed into tests
d1f017d
@leylayaltiligil
Added param to security change email to ensure subject reads as the c…
5702946 
…hange
@leylayaltiligil leylayaltiligil changed the title Send notification when user changes security information EAS-2430 Send notification when user changes security information Jan 16, 2025
Adam-C-Mitchell
Adam-C-Mitchell reviewed Jan 24, 2025
View reviewed changes
app/user/rest.py Outdated Show resolved Hide resolved
Adam-C-Mitchell
Adam-C-Mitchell reviewed Jan 24, 2025
View reviewed changes
app/user/rest.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adam-C-Mitchell Adam-C-Mitchell Adam-C-Mitchell approved these changes

@gds-gharper gds-gharper Awaiting requested review from gds-gharper

@jonathan-owens-gds jonathan-owens-gds Awaiting requested review from jonathan-owens-gds

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leylayaltiligil @Adam-C-Mitchell