Do not install yarn latest in docker build #2968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the documentation for `yarn set version`:
The version specifier can be:
- a tag:
- `latest` / `berry` / `stable` -> the most recent stable berry (`>=2.0.0`)
release
So `yarn set version berry` is equivalent to `yarn set version latest`,
which will install newly released versions of yarn.
There was a release of yarn v4.0.0 yesterday - https://github.com/yarnpkg/berry/releases/tag/%40yarnpkg%2Fcli%2F4.0.0
which is now breaking the build, because it produces a slightly
different lockfile.
The docker build should use whichever yarn version package.json uses,
not install the latest version on the fly.
sengi
approved these changes
Oct 23, 2023
|
There might be a bunch more of these - istr it was a workaround for something. (edit: apparently it was only in this and Frontend.) |
richardTowers
added a commit
to alphagov/frontend
that referenced
this pull request
Oct 23, 2023
As per the documentation for `yarn set version`:
The version specifier can be:
- a tag:
- `latest` / `berry` / `stable` -> the most recent stable berry (`>=2.0.0`) release
So `yarn set version berry` is equivalent to `yarn set version latest`, which will install newly released versions of yarn.
There was a release of yarn v4.0.0 yesterday - https://github.com/yarnpkg/berry/releases/tag/%40yarnpkg%2Fcli%2F4.0.0 which is now breaking the build, because it produces a slightly different lockfile.
The docker build should use whichever yarn version package.json uses, not install the latest version on the fly.
See also: alphagov/government-frontend#2968
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the documentation for
yarn set version:So
yarn set version berryis equivalent toyarn set version latest, which will install newly released versions of yarn.There was a release of yarn v4.0.0 yesterday - https://github.com/yarnpkg/berry/releases/tag/%40yarnpkg%2Fcli%2F4.0.0 which is now breaking the build, because it produces a slightly different lockfile.
The docker build should use whichever yarn version package.json uses, not install the latest version on the fly.