Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump govuk_publishing_components from 35.23.0 to 36.0.1" #3000

Merged

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Nov 30, 2023

Reverts #2998

I think what has happened has:

  • I've introduced a new meta tag
  • This tries to dig into the content item and grab the first key in the array (content_item.dig(:links, :government, 0))
  • However, in Ruby digs, I think it crashes if government is not an array and it tries to dig into it, instead of returning nil
  • I think some content items do not have the array, as the tests that fail run GovukSchemas::RandomExample - so depending on what it returns, I think it passes or fails depending on the structure of the content item. So the dependabot passed, but it failed on main as they grabbed different content items.
  • I will revert this and fix it in publishing components

Example of failing CI: https://github.com/alphagov/government-frontend/actions/runs/7049040483/attempts/2

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3000 November 30, 2023 16:25 Inactive
@AshGDS AshGDS merged commit 3b7283b into main Nov 30, 2023
11 checks passed
@AshGDS AshGDS deleted the revert-2998-dependabot/bundler/govuk_publishing_components-36.0.1 branch November 30, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants