WIP - Move AB test configuration into YAML #3033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an idea / illustration of an approach for doing AB tests of
content in a slightly more maintainable way.
I still really don't like having them hard-configured in the codebase,
so I'm not actually in favour of merging this.
What I'm trying to show is that if we provide government-frontend with
the right bits of config, it's capable of dynamically adding the AB
tests needed for a particular content item. If we can do that with a
YAML file, then we could potentially do it with information on the
content item itself.
I'm imagining a world where we have something like:
{
...
"first_published_at": "2016-02-26T11:53:52Z",
"links": {
"ab_tests": [
{
"name": "FindUtrNumberVideoLinks",
"dimension": 61,
"base_paths": ["/find-utr-number"],
"variants": [
...
in the content item, and the code works out everything from that.
We could also have something listening to the publishing queue and
configuring the Fastly dictionaries whenever this linked item updated.
If this idea is popular, I'll write it up as an RFC.
richardTowers
force-pushed
the
ab-tests-from-config
branch
from
7d72362 to
20e5bcc
Compare
This is in a separate config file in this branch
... I've deleted the translations now, which broke the tests.
We don't need to worry about allowlisting base paths once the config is coming from the content-item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an idea / illustration of an approach for doing AB tests of content in a slightly more maintainable way.
I still really don't like having them hard-configured in the codebase, so I'm not actually in favour of merging this.
What I'm trying to show is that if we provide government-frontend with the right bits of config, it's capable of dynamically adding the AB tests needed for a particular content item. If we can do that with a YAML file, then we could potentially do it with information on the content item itself.
I'm imagining a world where we have something like:
in the content item, and the code works out everything from that.
We could also have something listening to the publishing queue and configuring the Fastly dictionaries whenever this linked item updated.
If this idea is popular, I'll write it up as an RFC.