Add component testing #3042
Merged
Add component testing #3042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no reference to it in the application - no YML file, no test file - already have a far more detailed heading component in the gem
- checks for component files and their correct naming conventions - 'context' requires `shoulda-context` gem for minitest (copying from `frontend`)
andysellick
force-pushed
the
add-component-testing
branch
from
a7da498 to
0731dbc
Compare
AshGDS
approved these changes
Jan 11, 2024
|
@AshGDS yes - |
|
@andysellick Same here 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improve component testing, specifically:
Why
Relates to alphagov/govuk_publishing_components#3369
Visual changes
None.