Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend h1 font-size in manuals to l #3084

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

CodeSonia
Copy link
Contributor

Trello

This PR addresses the styling of H1 headers in manual pages, so there is a visual distinction between H1s and H2s.

The fix involves adjusting the font size in the _manual_section_layout.html.erb partial, increasing it from m to l.This ensures that H1s now render with a font size of l and apply the govuk-heading-l class for improved visual differentiation.

Additionally, modified the Manual Section Test to resolve an error that occurred due to an ambiguous match in the rendered document heading.

Census Dates

Before:
image

After:
image

PAYE Manual

Before:
image

After:
image

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3084 February 8, 2024 16:29 Inactive
@CodeSonia CodeSonia force-pushed the amend-h1-manuals-size branch from 792718f to 2a3a12d Compare February 21, 2024 14:28
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3084 February 21, 2024 14:28 Inactive
Copy link
Contributor

@MartinJJones MartinJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, nice work! 👍

@MartinJJones MartinJJones merged commit ba9910c into main Feb 21, 2024
12 checks passed
@MartinJJones MartinJJones deleted the amend-h1-manuals-size branch February 21, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants