Update NewsImage to render multiple defaults #3096
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic to render an image for a news item is: - render the details > image if there is one - render the organisation > default image if there is one - render a placeholder Organisation here could be one of two types: - Organisation, presented in the primary_publishing_organisation link - WorldwideOrganisation, presented in the worldwide_organisations link The placeholder is also dependent on which type of document and so which type of organisation the content links to. Here we allow the module to render the default image from the worldwide organisation link, when the document is the appropriate type and one is available. Right now this change will not be used as Whitehall currently sets details > image to the default image for worldwide organisation news items, but this is set to change as we want this logic out of the publishing applications and for all related concepts like 'the default news image' to work the same way. With this change, once we do turn the replacement in Whitehall off, everything will continnue to work without change.
The placeholder image and default news image both depend on whether the content item is a world news story.
jkempster34
force-pushed
the
feature/news-image-can-render-linked-worldwide-organisation-default-image
branch
from
645b30c to
822511a
Compare
brucebolt
approved these changes
Feb 28, 2024
Comment on lines
+25
to
+26
| worldwide_organisation = content_item.dig("links", "worldwide_organisations") | ||
| worldwide_organisation[0].dig("details", "default_news_image") if worldwide_organisation.present? |
There was a problem hiding this comment.
Minor nitpick where I think first would be nicer than accessing with a numeric position. The first method still returns nil if there's an empty array.
Suggested change
| worldwide_organisation = content_item.dig("links", "worldwide_organisations") | |
| worldwide_organisation[0].dig("details", "default_news_image") if worldwide_organisation.present? | |
| worldwide_organisation = content_item.dig("links", "worldwide_organisations").first | |
| worldwide_organisation.dig("details", "default_news_image") if worldwide_organisation.present? |
|
|
||
| def first_primary_publishing_organisation_default_news_image | ||
| organisation = content_item.dig("links", "primary_publishing_organisation") | ||
| organisation[0].dig("details", "default_news_image") if organisation.present? |
There was a problem hiding this comment.
Same here as my previous comment.
jkempster34
added a commit
to alphagov/whitehall
that referenced
this pull request
Feb 28, 2024
Unless a user has added a specific news image for a news article, then a default image is retrieved from an associated organisation or worldwide organisation. Currently, the default image is surfaced as an `image` in the details of a news story. However, this is problematic because the default image does not update through dependency resolution when the image is changed on the associated organisation or worldwide organisation. This sets the image as nil if the article has a default image. Government Frontend will render the default news image when the details image is absent (alphagov/government-frontend#3096), allowing us to replicate the functionality we are removing here through link expansion instead.
jkempster34
added a commit
to alphagov/whitehall
that referenced
this pull request
Feb 28, 2024
Unless a user has added a specific news image for a news article, then a default image is retrieved from an associated organisation or worldwide organisation. Currently, the default image is surfaced as an `image` in the details of a news story. However, this is problematic because the default image does not update through dependency resolution when the image is changed on the associated organisation or worldwide organisation. This sets the image as nil if the article has a default image. Government Frontend will render the default news image when the details image is absent (alphagov/government-frontend#3096), allowing us to replicate the functionality we are removing here through link expansion instead.
|
We considered including default news image as a link instead of relying on ActiveRecord callbacks. However:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic to render an image for a news item is:
Organisation here could be one of two types:
The placeholder is also dependent on which type of document and so which
type of organisation the content links to.
Here we allow the module to render the default image from the worldwide
organisation link, when the document is the appropriate type and one is
available.
Right now this change will not be used as Whitehall currently sets
details > image to the default image for worldwide organisation news
items, but this is set to change as we want this logic out of the
publishing applications and for all related concepts like 'the default
news image' to work the same way.
With this change, once we do turn the replacement in Whitehall off,
everything will continnue to work without change.
Follow these steps if you are doing a Rails upgrade.