Make test mocks internal and import with @testable.

Fix variable declaration

GOVKit/Sources/GOVKit/ViewControllers/BaseViewController.swift

@@ -3,7 +3,7 @@ import Foundation
 
 @MainActor
 open class BaseViewController: UIViewController {
-    private(set) public var analyticsService: AnalyticsServiceInterface
+    public let analyticsService: AnalyticsServiceInterface
 
     public init(analyticsService: AnalyticsServiceInterface) {
         self.analyticsService = analyticsService

GOVKit/Sources/GOVKitTestUtilities/Mocks/MockBaseViewController.swift

@@ -2,19 +2,19 @@ import Foundation
 import GOVKit
 
 @MainActor
-public class MockBaseViewController: BaseViewController,
-                                     TrackableScreen {
-    public var trackingName: String { "test_mock_tracking_name" }
-    public var additionalParameters: [String : Any] { ["test_param": "test_value"] }
-
-    public var _receivedBeginAppearanceTransitionAnimated: Bool?
-    public override func beginAppearanceTransition(_ isAppearing: Bool, animated: Bool) {
+class MockBaseViewController: BaseViewController,
+                              TrackableScreen {
+    var trackingName: String { "test_mock_tracking_name" }
+    var additionalParameters: [String : Any] { ["test_param": "test_value"] }
+    
+    var _receivedBeginAppearanceTransitionAnimated: Bool?
+    override func beginAppearanceTransition(_ isAppearing: Bool, animated: Bool) {
         super.beginAppearanceTransition(isAppearing, animated: animated)
         _receivedBeginAppearanceTransitionAnimated = animated
     }
-
-    public var _endAppearanceTransitionCalled: Bool = false
-    public override func endAppearanceTransition() {
+    
+    var _endAppearanceTransitionCalled: Bool = false
+    override func endAppearanceTransition() {
         super.endAppearanceTransition()
         _endAppearanceTransitionCalled = true
     }

GOVKit/Sources/GOVKitTestUtilities/Mocks/MockNotificationCenter.swift

@@ -1,10 +1,10 @@
 import Foundation
 
-public class MockNotificationCenter: NotificationCenter,
-                                     @unchecked Sendable {
-
-    public var _receivedObservers: [(name: NSNotification.Name, object: Any)] = []
-    public override func addObserver(
+class MockNotificationCenter: NotificationCenter,
+                              @unchecked Sendable {
+    
+    var _receivedObservers: [(name: NSNotification.Name, object: Any)] = []
+    override func addObserver(
         forName name: NSNotification.Name?,
         object obj: Any?,
         queue: OperationQueue?,

Tests/govuk_ios/govuk_ios_unit_tests/Specs/Clients/CrashlyticsClientTests.swift

@@ -1,7 +1,7 @@
 import Foundation
 import Testing
-import GOVKitTestUtilities
 
+@testable import GOVKitTestUtilities
 @testable import govuk_ios
 
 @Suite

Tests/govuk_ios/govuk_ios_unit_tests/Specs/Clients/FirebaseClientTests.swift

@@ -3,8 +3,8 @@ import Testing
 
 import FirebaseAnalytics
 import GOVKit
-import GOVKitTestUtilities
 
+@testable import GOVKitTestUtilities
 @testable import govuk_ios
 
 @Suite(.serialized)

Tests/govuk_ios/govuk_ios_unit_tests/Specs/Extensions/UIKit/UIViewController+ExtensionsTests.swift

@@ -1,8 +1,8 @@
 import Foundation
 
 import Testing
-import GOVKitTestUtilities
 
+@testable import GOVKitTestUtilities
 @testable import govuk_ios
 
 @Suite

Tests/govuk_ios/govuk_ios_unit_tests/Specs/Repositories/CoreDataRepositoryTests.swift

@@ -1,9 +1,9 @@
 import Foundation
 import CoreData
 import Testing
-import GOVKitTestUtilities
 import RecentActivity
 
+@testable import GOVKitTestUtilities
 @testable import govuk_ios
 
 @Suite

Tests/govuk_ios/govuk_ios_unit_tests/Specs/Services/AnalyticsServiceTests.swift

@@ -2,8 +2,8 @@ import UIKit
 import Foundation
 import Testing
 import GOVKit
-import GOVKitTestUtilities
 
+@testable import GOVKitTestUtilities
 @testable import govuk_ios
 
 @Suite