Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Fastlane workflows #2

Merged
merged 42 commits into from
Apr 25, 2024
Merged

Added Fastlane workflows #2

merged 42 commits into from
Apr 25, 2024

Conversation

batesyuk
Copy link
Contributor

No description provided.

@batesyuk batesyuk requested a review from a team as a code owner April 22, 2024 08:26
Copy link
Contributor

@1pretz1 1pretz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Left some minor comments / questions. I've also embodied a linter (😄) so the most obvious step would be to add one but may not be worth it due to the limited Ruby code we're adding.

Could also just install the rubocop gem, and run rubocop -A locally which will autofix / suggest fixes.

Fastlane/Configuration.rb Outdated Show resolved Hide resolved
Fastlane/Configuration.rb Outdated Show resolved Hide resolved
Fastlane/Configuration.rb Outdated Show resolved Hide resolved
.github/workflows/pull_request.yaml Outdated Show resolved Hide resolved
.github/workflows/pull_request.yaml Show resolved Hide resolved
Fastlane/Fastfile Show resolved Hide resolved
Fastlane/Fastfile Show resolved Hide resolved
Fastlane/Fastfile Show resolved Hide resolved
Fastlane/.build.yml Outdated Show resolved Hide resolved
Fastlane/Configuration.rb Outdated Show resolved Hide resolved
@batesyuk batesyuk force-pushed the feature/Fastlane branch 2 times, most recently from a399e74 to 276dc0e Compare April 22, 2024 19:40
Copy link
Contributor

@1pretz1 1pretz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Tom, workflows look great! Ideally commits will be tidied up before merge 😄

Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@batesyuk batesyuk merged commit 3db5bd4 into develop Apr 25, 2024
3 checks passed
@batesyuk batesyuk deleted the feature/Fastlane branch April 25, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants