[GOVUKAPP-1024] Update edit actions voice over text #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdubey
previously approved these changes
Jan 7, 2025
There was a problem hiding this comment.
I noticed when testing that if you begin editing "Pages you've visited", the title of the button changes to "Done", but VO still reads "Edit pages you've visited, button, double-tap to activate". This feels confusing, and should probably be changed. Don't know if you want to address it in this ticket or open a new one.
1pretz1
force-pushed
the
update-edit-vo
branch
2 times, most recently
from
41e805f to
5ebb465
Compare
|
Good spot @joshdubey! I've updated the PR so the 'done' VO is respected. Also added the hint to both 'edit' and 'done' for consistency. |
joshdubey
previously approved these changes
Jan 7, 2025
Production/govuk_ios/ViewControllers/RecentActivityListViewController.swift
Outdated
Show resolved
Hide resolved
1pretz1
force-pushed
the
update-edit-vo
branch
from
5ebb465 to
a52a292
Compare
Following accessibility audit.
Also moves RecentActivitySection to own file.
1pretz1
force-pushed
the
update-edit-vo
branch
from
a52a292 to
54337c0
Compare
|
joshdubey
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following accessibility audit.