GOVUKAPP-975 Recent Activities modularisation #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontstantsTests/BaseViewControllerTests to GOVKit
# Conflicts: # GovUK.xcodeproj/project.pbxproj # Production/govuk_ios/Extensions/Foundation/String+Extensions.swift
batesyuk
reviewed
Jan 8, 2025
GOVKit/Sources/GOVKit/Extensions/Analytics/AppEvent+Function.swift
Outdated
Show resolved
Hide resolved
GOVKit/Sources/GOVKit/Extensions/Analytics/AppEvent+Navigation.swift
Outdated
Show resolved
Hide resolved
GOVKit/Sources/GOVKit/Extensions/Foundation/Date+Extensions.swift
Outdated
Show resolved
Hide resolved
GOVKit/Sources/GOVKit/Extensions/Foundation/String+Extensions.swift
Outdated
Show resolved
Hide resolved
GOVKit/Sources/GOVKit/Extensions/CoreData/NSFetchedResultsController+Extensions.swift
Outdated
Show resolved
Hide resolved
GOVKit/Sources/GOVKit/Views/Common/TopAlignedBarButtonItem.swift
Outdated
Show resolved
Hide resolved
GOVKit/Sources/GOVKitTestUtilities/Mocks/MockNotificationCenter.swift
Outdated
Show resolved
Hide resolved
RecentActivity/Sources/RecentActivity/Model/RecentActivity/ActivityItem.swift
Outdated
Show resolved
Hide resolved
joshdubey
force-pushed
the
feature/GOVUKAPP-975-modularisation
branch
from
e350bba to
a5d1cd0
Compare
batesyuk
previously approved these changes
Jan 13, 2025
# Conflicts: # GOVKit/Sources/GOVKit/Views/Common/TopAlignedBarButtonItem.swift # GovUK.xcodeproj/project.pbxproj # Production/govuk_ios/Builders/ViewControllerBuilder.swift # Production/govuk_ios/ViewControllers/TestViewController.swift # RecentActivity/Sources/RecentActivity/Model/RecentActivity/RecentActivitySection.swift # RecentActivity/Sources/RecentActivity/ViewControllers/RecentActivityListViewController.swift # Tests/govuk_ios/govuk_ios_unit_tests/Mocks/Builders/MockViewControllerBuilder.swift # Tests/govuk_ios/govuk_ios_unit_tests/Specs/Builders/ViewControllerBuilderTests.swift
joshdubey
force-pushed
the
feature/GOVUKAPP-975-modularisation
branch
from
40850b7 to
9053330
Compare
|
batesyuk
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new SPM modules: GOVKit and RecentActivity
GOVKit contains objects that are shared across the app and other modules. The intent is that modules for future features would be able to utilize GOVKit to accelerate development and create a consistent architecture.
GOVKit has two products: GOVKit and GOVKitTestUtilities. GOVKit has core classes and components for developing additional modules. GOVKitTestUtilities contains mocks and helper classes for more easily setting up unit tests.
RecentActivity encapsulates the RecentActivity feature, containing components for creating the UI, as well as service and repository classes. It relies on the consumer (i.e. GOVUK app) to supply the concrete core data implementation, including the xcdatamodel. Testing is facilitated by creating the core data model programatically, as it is not possible to have an xcdatamodel as a testing resource.
Much of the PR involves movement of code from the app to the modules, with little change except for imports. A change of note was to remove the use of @injected from BaseViewController, and instead inject the Analytics service in the initializer, as is done for all other services. This was to remove the Factory dependency from GOVKit, to help simplify the refactor.
The new packages have their own test plans, as trying to include them in the app test plan was proving difficult, and one would assume they will ultimately be in their own repositories and be tested separately anyway.