Merge pull request #4480 from alphagov/change-button-type-in-copy-to-…

…clipboard Use correct button type for copy to clipboard component
alphagov · Dec 6, 2024 · 2197104 · 2197104
2 parents a61847b + ba1a8d1
commit 2197104
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,7 @@
 ## Unreleased
 
 * Use component wrapper on reorderable list component ([PR #4474](https://github.com/alphagov/govuk_publishing_components/pull/4474))
+* Use "button" button type for copy to clipboard component ([PR 4480](https://github.com/alphagov/govuk_publishing_components/pull/4480))
 
 ## 46.2.0
 

diff --git a/app/views/govuk_publishing_components/components/_copy_to_clipboard.html.erb b/app/views/govuk_publishing_components/components/_copy_to_clipboard.html.erb
@@ -15,6 +15,7 @@
 
   <%= render "govuk_publishing_components/components/button", {
     text: button_text,
+    type: "button",
     data_attributes: button_data_attributes,
     secondary_quiet: true,
   } %>

diff --git a/spec/components/copy_to_clipboard_spec.rb b/spec/components/copy_to_clipboard_spec.rb
@@ -14,6 +14,6 @@ def component_name
 
     assert_select "label", text: "Some label"
     assert_select "input", value: "https://www.example.org"
-    assert_select "button", value: "Copy link"
+    assert_select "button[type=\"button\"]", value: "Copy link"
   end
 end