**BREAKING** Add component wrapper helper to the list component #4441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
changed the title
AshGDS
force-pushed
the
list-component-wrapper
branch
3 times, most recently
from
61869ab to
4cdccfe
Compare
AshGDS
changed the title
AshGDS
force-pushed
the
list-component-wrapper
branch
from
4cdccfe to
d445d35
Compare
Also removes the shared_helper functionality, as margin_bottom is now handled within the component wrapper.
AshGDS
force-pushed
the
list-component-wrapper
branch
from
d445d35 to
6561d1e
Compare
andysellick
approved these changes
Jan 10, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
listcomponent.aria_labelto set its label, but now it should use the component wrapper functionality.Why
As the trello card states:
Visual changes
None.