Use the RuboCop Rails config #4471
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-kirwan
force-pushed
the
use-rubocop-rails-config
branch
from
79a3663 to
14fe189
Compare
jon-kirwan
force-pushed
the
use-rubocop-rails-config
branch
3 times, most recently
from
349da96 to
0e43f92
Compare
I'm uncertain about this one. According to the documentation: "this cop checks rake task definitions to ensure they include the environment dependency. The environment dependency is essential because it loads the application code for the rake task. Without it, the rake task cannot use application code, like models." However, I don't see this cop being configured in other applications that use the Rails.yml configuration.
jon-kirwan
force-pushed
the
use-rubocop-rails-config
branch
from
0e43f92 to
306a0f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use the RuboCop Rails config and fix the offenses identified by the following cops:
Rails/Blank,Rails/Presence,Rails/PresentRails/DelegateRails/FilePathRails/OutputRails/RakeEnvironmentRails/TimeZoneStyle/RedundantParenthesesWhy
For consistency with other frontend applications that use the Rails configuration. See #2626
Anything else
HelperInstanceVariableoffenses are still not being detected which is because RuboCop only checks view helpers located in/app/helpers. See https://github.com/rubocop/rubocop-rails/blob/master/config/default.yml#L553-L558Rails/RakeEnvironment. RuboCop autocorrect applies this change by default, but I’m not sure whether we should keep it or if disabling that specific cop might be a better approach